Re: patches for pkgsrc/multimedia/libdv

[Osamu OISHI <oishi@ims.ac.jp>]

"Jeremy C. Reed" wrote:
> 
> If libdv is not built with at least -O it fails to build.
> See FreeBSD PR http://www.FreeBSD.org/cgi/query-pr.cgi?pr=52024
> 
> I notice this under Linux with Pkgsrc because I didn't have -O by default
> in my CFLAGS.
> 
> May I commit this?
> 
> --- multimedia/libdv/Makefile   3 Jan 2005 12:48:29 -0000       1.8
> +++ multimedia/libdv/Makefile   10 Feb 2005 00:42:09 -0000
> @@ -16,6 +16,7 @@
>  PTHREAD_AUTO_VARS=     yes
> 
>  LIBS+=                 ${LIBOSSAUDIO}
> +CFLAGS+=               -O
> 
>  .include "../../mk/bsd.prefs.mk"
>  .if empty(MACHINE_PLATFORM:M*-*-i386)
> 
>  Jeremy C. Reed

No problem occur in the following environments 
as described in libdv/README.html. 
   i386:    libdv-0.1022(NetBSD-2.0)
   sparc64: libdv-0.1022(NetBSD-2.0)
   sparc:   libdv-0.1022(NetBSD-2.0)

(It is the same also on libdv-0.103 or libdv-0.104.) 

Therefore, the problem depended on your environment 
when the problem ocurred on linux. 

To solve the problem of an environmental dependency, 
the following description is added to libdv/Makefile. 
   .include "../../devel/pkgconfig/buildlink3.mk"

At least, the change of (-O2 -> -O) decreases the execution speed 
and is harmful in the environment such as NetBSD-i386.
And, it is not accepted to apply such a change to all the environments. 

The solution with "pkgconfig" seems a better method 
though it is possible to add the following descriptions 
on limited linux environment, 
if the problem is reproduced on all linux. 
   +.if !empty(MACHINE_PLATFORM:MLinux-*-*)
   +CFLAGS+=               -O
   +.endif

regards.
--
Osamu OISHI